andygrove commented on PR #5854: URL: https://github.com/apache/datafusion-comet/pull/5854#issuecomment-5719749804
Triage note: #5844 also makes `map_from_arrays` work under `mapKeyDedupPolicy=LAST_WIN`, but by mixing `CodegenDispatchFallback` into `CometMapFromArrays` rather than running it natively. It keeps `MapKeyDedupPolicySupport`, which this PR deletes, and rewrites the same `map_from_arrays_dedup_policy.sql` fixture, so the two cannot both land as written. I think the native route is the one we want here, provided DataFusion's kernel matches `ArrayBasedMapBuilder` on ordering as well as dedup. Worth a word with @LinSimon-901101 so that PR is not reworked further against a shape that is about to disappear. Separately, #5846 is fixing per-row length validation and null short-circuiting in the same native `map_from_arrays` path, so there is a three-way sequencing question in `map_funcs/mod.rs` worth sorting out with @sunchao as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
