neilconway opened a new pull request, #25431: URL: https://github.com/apache/datafusion/pull/25431
## Which issue does this PR close? - Closes #25419. ## Rationale for this change In `datafusion-spark`, `map_from_arrays` and `map_from_entries` return wrong results when their input list array is sliced. The values are correct, but the keys come from rows outside the slice. ## What changes are included in this PR? * Fix the shared helper `map_deduplicate_keys` to behave correctly by slicing the input key range down to only the currently visible keys * Add `debug_assert` to check a useful invariant * Update various comments * Add unit tests * Add SLTs ## What is the testing strategy for this PR? Existing tests pass, new tests added. ## Are there any user-facing changes? No, aside from bugfix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
