sunchao commented on PR #5420: URL: https://github.com/apache/datafusion-comet/pull/5420#issuecomment-5721511682
Andy, I simplified the AVG patch further in [42a6bad39](https://github.com/apache/datafusion-comet/commit/42a6bad3938e611f4737485d7454f692f8053040). This supersedes the grouped ANSI policy in my previous reply: grouped AVG now remains `Compatible()`, with the eager batch/LIMIT overflow difference documented under known divergences, as you suggested. That removes the blanket fallback, operator opt-in tests, benchmark, and all six associated golden snapshots. The scalar decimal accumulator also uses one update loop, and the test coverage is consolidated around distinct failures: empty partials crossing engines in both directions, sticky overflow, grouped state round trips with a zeroed null-count payload, and the 27/28 precision boundary. The grouped columnar-shuffle test includes overflowing, valid, and all-null groups and checks legacy, TRY, and ANSI behavior. The reviewed #5421 prerequisite remains intact, wide-decimal shuffle remains separate in #6005, and the window guard stays AVG-only with decimal SUM documented under #6002. Beyond the prerequisite on the same main baseline, the patch is now **+571/-216**, down from **+1475/-224**. No benchmark or golden-file changes remain here. Full-reactor Spark 4.1.3 test compilation, formatting/style checks, all 37 planner tests, and all 129 TPC-DS plan checks pass. The planning checks use a verified main native library only for initialization. [Current-head CI](https://github.com/apache/datafusion-comet/actions/runs/35276146413) has `run-all-spark-profiles`; native execution results are pending because the configured local registry cannot resolve locked DataFusion 55.1.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
