Copilot commented on code in PR #25335:
URL: https://github.com/apache/datafusion/pull/25335#discussion_r4041740638
##########
datafusion/datasource-parquet/src/opener/mod.rs:
##########
@@ -3932,8 +3936,7 @@ mod test {
.fetch_metadata()
.await
.unwrap();
- assert!(original.column_index().is_some());
- assert!(original.offset_index().is_some());
+ assert!(original.page_index().is_some());
Review Comment:
This weakens the previous check that both column and offset indexes were
loaded: `page_index()` can be `Some` for a partial provider. Since this setup
is intended to exercise cached metadata containing the full page index, assert
`is_complete()` so a regression that loads only one index cannot pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
