Xuanwo opened a new pull request, #25492: URL: https://github.com/apache/datafusion/pull/25492
## Which issue does this PR close? Minor follow-up to #25371. ## Rationale for this change Workspace Clippy fails on main (`a522cd5bcedabd6238a0462b881a7ef4cb5c6f66`) with `clippy::large_enum_variant` in `LoadOutcome`. After the segmented batch layout change, `Chunk` contains at least 201 bytes while `Empty` carries no data. Reproduced on aarch64 macOS with Rust 1.98.1: ```sh cargo clippy --workspace --all-targets --all-features -- -D warnings ``` ## What changes are included in this PR? Store `Arc<JoinLeftData>` in `LoadOutcome::Chunk`. Construct the Arc when loading completes and reuse it when publishing the chunk. The successful path already allocated this Arc during publication, so this reduces the enum size without adding another allocation or changing the shared chunk ownership. ## What is the testing strategy for this PR? The Clippy command above fails before the change and passes after it. Existing NLJ tests cover coordinated spilling, cancellation, and memory reservation lifetimes; no new behavior is introduced. Validation: - `cargo fmt --all` - `cargo clippy --workspace --all-targets --all-features -- -D warnings` - `cargo test -p datafusion-physical-plan --lib joins::nested_loop_join` (90 passed) - `cargo test --test sqllogictests -- nested_loop_join_spill` (passed) - `uv run ./dev/rust_lint.sh` (full suite passed) ## Are there any user-facing changes? No query or public API changes. This restores the workspace Clippy check. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
