namanjain24-sudo commented on code in PR #25498: URL: https://github.com/apache/datafusion/pull/25498#discussion_r4054292728
########## datafusion/functions/src/datetime/date_trunc.rs: ########## Review Comment: Ran it against the branch's base (ccfe704) on the same machine, together with the other `date_trunc` benches: `date_trunc_minute_1000` went from 1.246 µs to 1.232 µs, and the rest are within noise. That matches the change, since the array hot loop is the same and only the unit table moved into a helper. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
