kosiew commented on code in PR #24924:
URL: https://github.com/apache/datafusion/pull/24924#discussion_r4060636211
##########
datafusion/common/src/config.rs:
##########
@@ -1065,6 +1065,13 @@ config_namespace! {
/// number of rows written is not roughly divisible by the soft max
pub soft_max_rows_per_output_file: ConfigNonZeroUsize, default =
non_zero_usize_default(50000000)
+ /// Target encoded size in bytes of output files when writing multiple.
+ /// Writers asynchronously report the cumulative encoded size as they
+ /// process RecordBatches. The final file size may exceed this limit
due
+ /// to batches buffered before the limit is observed, the size of a
batch,
+ /// and file metadata written when the file is finalized.
+ pub soft_max_bytes_per_output_file: ConfigNonZeroUsize, default =
non_zero_usize_default(4294967295)
Review Comment:
Adding this field breaks downstream struct literals.
Could we either follow the project's approved breaking API process,
including any required upgrade or release documentation, or use a compatible
design?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
