adriangb commented on code in PR #25123:
URL: https://github.com/apache/datafusion/pull/25123#discussion_r4072830828
##########
datafusion/functions-aggregate-common/src/aggregate/groups_accumulator.rs:
##########
@@ -235,14 +235,23 @@ impl GroupsAccumulatorAdapter {
assert_eq!(values[0].len(), group_indices.len());
+ // groups_with_rows holds a list of group indexes that have any rows
+ // that need to be accumulated, stored in order of first appearance in
+ // this batch
+ let mut groups_with_rows = vec![];
Review Comment:
Filed into https://github.com/apache/datafusion/issues/25604
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
