alexanderbianchi commented on code in PR #14:
URL: https://github.com/apache/datafusion-iceberg/pull/14#discussion_r4076136269
##########
crates/datafusion/src/physical_plan/project.rs:
##########
Review Comment:
On thing I noticed - this uses `arc::ptr_eq` but
```rust
PartitionExpr::try_new(...)
```
will have a new memory address.
Now that `PartitionExpr` can be reconstructed, should its existing
pointer-based `PartialEq` and `Hash` implementations remain identity-based? A
reconstructed expression produces the same values but compares unequal because
it has a new calculator `Arc`. This may be intentional, but it would be helpful
to clarify the intended equality semantics. Ditto for `Hash`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
