dwsmith1983 commented on code in PR #5864: URL: https://github.com/apache/datafusion-comet/pull/5864#discussion_r4081198617
########## docs/source/user-guide/latest/expressions.md: ########## @@ -415,8 +415,8 @@ The type-name conversion functions (`bigint`, `binary`, `boolean`, `date`, `deci | --- | --- | --- | --- | | `%` | ✅ | Native | | | `*` | ✅ | Native | DayTime interval multiplication routes through the JVM codegen dispatcher; YearMonth and Calendar interval multiplication fall back | -| `+` | ✅ | Native | | -| `-` | ✅ | Native | | +| `+` | ✅ | Native | Adding a calendar, year-month or day-time interval to a date or timestamp routes through the JVM codegen dispatcher | Review Comment: > Could the notes carve it out? Yes. 7da1370fc changes the `+` and `-` notes to say that `date +/- INTERVAL '<n>' DAY` is rewritten to `date_add` and stays native, and that only a DAY-precision interval column reaches `ExtractANSIIntervalDays`, which has no serde, so that projection falls back. The 14 September wording had put both spellings under the fallback, which was wrong for the folded literal. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
