asolimando commented on issue #25610: URL: https://github.com/apache/datafusion/issues/25610#issuecomment-5796373296
A subset of the tasks are strongly linked to https://github.com/apache/datafusion/issues/21120 as they require to propagate through expressions, and you don't want to do that in multiple operators, @2010YOUY01 [suggested](https://github.com/apache/datafusion/pull/21122#pullrequestreview-4343582878) to first add support at the `PhysicalExpr` level, and this is what I am currently working on in a local branch as a pre-requisite for https://github.com/apache/datafusion/issues/21120. Here is the list of epic tasks I have in mind that should be addressed within the expression-level framework: https://github.com/apache/datafusion/issues/25612 https://github.com/apache/datafusion/issues/25614 https://github.com/apache/datafusion/issues/25620 https://github.com/apache/datafusion/issues/25621 I see @kumarUjjawal has already opened a PR for https://github.com/apache/datafusion/issues/25620 which had to modify join and filter (as both can have those filtering expressions), while ideally, we could address this at the `PhysicalExpr` level for binary predicates once and reuse everywhere needed (I hope to have a PR ready for review in a week or two, top). Just to be clear: I have nothing against moving forward as-is and possibly consolidate later, but my suggestion would be to start from the rest of the tickets at the "operator level" to avoid repeated work. What do you guys think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
