jayzhan211 commented on PR #25575: URL: https://github.com/apache/datafusion/pull/25575#issuecomment-5797397833
A central fallback in `ScalarFunctionExpr::get_properties` makes sense as a follow-up, and I'd keep this PR as is. Columns already get typed unbounded ranges (`equivalence/properties/mod.rs:1618`), so the consumers that read `range.data_type()` (date_trunc, cast, binary time ± interval) already handle typed-unbounded input. A few things to check there: - keep the `Null` interval if `make_unbounded(return_type)` errors, rather than failing planning - replace only an unbounded `Null` result, never real bounds from the UDF - leave `PhysicalExpr::evaluate_bounds` (the cp_solver path) unchanged - add negative plan tests: a named-timezone function output, and time ± interval through a function Once that lands, the `date_bin`/`from_unixtime` overrides here can be removed. Agree that `DataType` in `ExprProperties` needs its own design discussion because of the API and FFI surface. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
