yinli-systems commented on PR #23225: URL: https://github.com/apache/datafusion/pull/23225#issuecomment-5800322399
Marked this ready after rechecking current `main`: `type_union_resolution_coercion` still falls through to the comparison-style `string_numeric_coercion`, so `COALESCE` can still choose a numeric type for arbitrary strings. The linked issue remains open, the patch is one semantic change plus focused type-coercion and SQL regressions, and GitHub reports it mergeable. @jayzhan211, could you please check whether preferring the existing union-context rule here matches the intended coercion contract? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
