adriangb commented on code in PR #25661:
URL: https://github.com/apache/datafusion/pull/25661#discussion_r4086053438
##########
datafusion/sql/src/unparser/dialect.rs:
##########
@@ -1116,6 +1151,15 @@ impl CustomDialectBuilder {
self
}
+ /// Customize whether the dialect supports dictionary syntax for struct
literals
+ pub fn with_supports_dictionary_syntax(
Review Comment:
Same here some examples of what `dictioanry syntax` is would be helpful
##########
datafusion/sql/tests/cases/plan_to_sql.rs:
##########
@@ -394,6 +397,75 @@ fn roundtrip_statement_with_dialect_3() -> Result<(),
DataFusionError> {
Ok(())
}
+#[test]
+fn roundtrip_statement_named_struct_for_dialects() -> Result<(),
DataFusionError> {
Review Comment:
Can you add SQL examples as code comments for each dialect, each
input/output, etc.? It'd help understand what is going on in the test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
