comphead commented on code in PR #12151:
URL: https://github.com/apache/datafusion/pull/12151#discussion_r1730137020
##########
datafusion/core/tests/fuzz_cases/sort_fuzz.rs:
##########
@@ -136,9 +136,9 @@ impl SortTest {
.sort_spill_reservation_bytes,
);
- let runtime_config = RuntimeConfig::new()
- .with_memory_pool(Arc::new(GreedyMemoryPool::new(pool_size)));
- let runtime = Arc::new(RuntimeEnv::new(runtime_config).unwrap());
+ let runtime_env = RuntimeConfig::new()
+
.with_memory_pool(Arc::new(GreedyMemoryPool::new(pool_size))).build();
+ let runtime = Arc::new(runtime_env.unwrap());
Review Comment:
we should avoid calling `.unwrap()` although its not related to the PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
