LucaCappelletti94 commented on PR #2562: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2562#issuecomment-5802823743
I think I explained the issue poorly. The existing fuzz targets on `main` are not failing. Rather, the new differential target is finding bugs that already exist on `main`. However, because this target does not exist on `main` yet, ClusterFuzzLite cannot establish that these failures are pre-existing. It therefore classifies them as new failures introduced by this PR, causing the CI check to fail. So while I agree that we should chip away at the findings before making these fuzzers blocking, my point is that we should first merge the three targets with their CI checks non-blocking. They will be particularly useful for PRs affecting the SQLite, PostgreSQL, and DuckDB dialects. I will update the CI so as to make it non-blocking, still red, and left to the reviewer judgement. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
