2010YOUY01 commented on code in PR #25695:
URL: https://github.com/apache/datafusion/pull/25695#discussion_r4091216392
##########
docs/source/contributor-guide/api-health.md:
##########
@@ -55,6 +59,10 @@ notice or a deprecation period. Examples include:
2. Operator APIs required by the optimizer to inspect or rewrite execution
plans
across crate boundaries.
+Do not expose internal APIs solely for tests or microbenchmarks. Some legacy
code
Review Comment:
This might be subjective, I think it's not a good idea to test or benchmark
against implementation details overall. I'm not so sure if there are any
special cases that require this pattern.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
