zhuqi-lucas commented on PR #25688: URL: https://github.com/apache/datafusion/pull/25688#issuecomment-5810550610
@alamb this is the first step from #25355 — `EnsureRequirements` is pulled out into a new `PhysicalAnalyzerRule` trait, and the planner runs analyzers then optimizers. To keep it a pure refactor I run the analyzer phase at `EnsureRequirements`' current position (right before `CombinePartialFinalAggregate`) rather than strictly first: running it before `JoinSelection` yields an invalid single-partition broadcast join, so this way every plan and the full sqllogictest suite stay unchanged. Would appreciate an early look at the trait / API shape before I build the convergence loop on top of it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
