zhuqi-lucas commented on PR #25688: URL: https://github.com/apache/datafusion/pull/25688#issuecomment-5812372370
Thanks @alamb, this is really helpful. Agreed on enforcement-first — I'll follow your sequencing: first a PR refactoring `JoinSelection` to update distribution itself via a reusable `Enforce` helper (so it runs after enforcement), then this PR pulls enforcement into an analyzer that runs first, and I'll pare down the comments here meanwhile. One thing I'd like to fold into that helper: make it invariant-gated so any rule that changes requirements can call it to self-repair cheaply when the plan is already valid, which keeps repeated enforcement from re-deriving the whole tree. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
