gruuya commented on PR #25602: URL: https://github.com/apache/datafusion/pull/25602#issuecomment-5812808516
> `│ QQuery 18 │ 59.39 / 61.74 ±1.44 / 63.59 ms │ 45.37 / 46.10 ±1.06 / 48.16 ms │ +1.34x faster │` Looks like there's a genuine improvement for TPCH Q18, but it's a side-effect of the changes not really benefiting from the bitmap pruning in that case. That side-effect is wiring the `CaseExpr` pruning in `build_predicate_expression`, which we need in order to get the bitmap pushdown for partitioned hash joins too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
