LinSimon-901101 opened a new pull request, #6182: URL: https://github.com/apache/datafusion-comet/pull/6182
## Which issue does this PR close? Closes #6080. ## Rationale for this change `make_timestamp` and `to_unix_timestamp` only use JVM codegen dispatch. Their collation-specific support overrides incorrectly advertise a native implementation that users can enable with `allowIncompatible`. ## What changes are included in this PR? - Remove the collation overrides and `CodegenDispatchFallback` mixin from both expressions, inheriting the compatible codegen-dispatch behavior. - Update Spark 4.0 and 4.1 tests to verify execution routing and diagnostics with codegen dispatch and `allowIncompatible` enabled and disabled. - Add a documentation regression test ensuring these expressions no longer produce native opt-in compatibility notes. ## How are these changes tested? Targeted local runs passed on JDK 21: - Spark 4.0: 34 tests passed. - Spark 4.1: 29 tests passed. Each run included `CometCollationSuite`, `GenerateDocsSuite`, and `CometSqlFileTestSuite` filtered to `routing_datetime_collation`, covering both the enabled and disabled SQL fixtures. These tests verify result parity, execution routing, diagnostics, and compatibility documentation. Native build, Scalastyle, and Spotless checks also passed. The full Spark SQL CI suite has not been run. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
