osipovartem commented on code in PR #2502:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/2502#discussion_r4094545785
##########
tests/sqlparser_snowflake.rs:
##########
@@ -44,6 +44,19 @@ fn test_snowflake_create_table() {
}
}
+#[test]
+fn parse_order_by_all() {
+ let query = snowflake()
+ .verified_query("SELECT value + 1 AS computed FROM source ORDER BY ALL
DESC NULLS FIRST");
+ assert_eq!(
+ query.order_by.expect("ORDER BY expected").kind,
+ OrderByKind::All(OrderByOptions {
+ sort: Some(OrderBySort::Desc),
+ nulls_first: Some(true),
+ })
+ );
+}
+
Review Comment:
Agreed. I removed the duplicate Snowflake-specific test in 712cb919. The
shared `parse_select_order_by_all` test covers Snowflake and all nine option
combinations; it passes, as does the full Snowflake test suite (167/167).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
