github-actions[bot] commented on PR #25707: URL: https://github.com/apache/datafusion/pull/25707#issuecomment-5816759399
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion-expr v55.1.0 (current) Built [ 36.936s] (current) Parsing datafusion-expr v55.1.0 (current) Parsed [ 0.080s] (current) Building datafusion-expr v55.1.0 (baseline) Built [ 29.983s] (baseline) Parsing datafusion-expr v55.1.0 (baseline) Parsed [ 0.079s] (baseline) Checking datafusion-expr v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 1.341s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 69.719s] datafusion-expr Building datafusion-expr-common v55.1.0 (current) Built [ 20.524s] (current) Parsing datafusion-expr-common v55.1.0 (current) Parsed [ 0.022s] (current) Building datafusion-expr-common v55.1.0 (baseline) Built [ 20.522s] (baseline) Parsing datafusion-expr-common v55.1.0 (baseline) Parsed [ 0.020s] (baseline) Checking datafusion-expr-common v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.214s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 42.256s] datafusion-expr-common Building datafusion-functions-aggregate v55.1.0 (current) Built [ 32.716s] (current) Parsing datafusion-functions-aggregate v55.1.0 (current) Parsed [ 0.045s] (current) Building datafusion-functions-aggregate v55.1.0 (baseline) Built [ 33.757s] (baseline) Parsing datafusion-functions-aggregate v55.1.0 (baseline) Parsed [ 0.047s] (baseline) Checking datafusion-functions-aggregate v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.174s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 67.884s] datafusion-functions-aggregate Building datafusion-functions-aggregate-common v55.1.0 (current) Built [ 22.282s] (current) Parsing datafusion-functions-aggregate-common v55.1.0 (current) Parsed [ 0.021s] (current) Building datafusion-functions-aggregate-common v55.1.0 (baseline) Built [ 22.138s] (baseline) Parsing datafusion-functions-aggregate-common v55.1.0 (baseline) Parsed [ 0.021s] (baseline) Checking datafusion-functions-aggregate-common v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.133s] 223 checks: 222 pass, 1 fail, 0 warn, 31 skip --- failure function_requires_different_generic_type_params: function now requires a different number of generic type parameters --- Description: A function now requires a different number of generic type parameters than it used to. Uses of this function that supplied the previous number of generic types (e.g. via turbofish syntax) will be broken. ref: https://doc.rust-lang.org/reference/items/generics.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/function_requires_different_generic_type_params.ron Failed in: function accumulate (2 -> 3 generic types) in /home/runner/work/datafusion/datafusion/datafusion/functions-aggregate-common/src/aggregate/groups_accumulator/accumulate.rs:421 function accumulate_indices (1 -> 2 generic types) in /home/runner/work/datafusion/datafusion/datafusion/functions-aggregate-common/src/aggregate/groups_accumulator/accumulate.rs:591 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 45.333s] datafusion-functions-aggregate-common Building datafusion-physical-expr v55.1.0 (current) Built [ 30.487s] (current) Parsing datafusion-physical-expr v55.1.0 (current) Parsed [ 0.049s] (current) Building datafusion-physical-expr v55.1.0 (baseline) Built [ 30.842s] (baseline) Parsing datafusion-physical-expr v55.1.0 (baseline) Parsed [ 0.051s] (baseline) Checking datafusion-physical-expr v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.335s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 62.960s] datafusion-physical-expr Building datafusion-physical-plan v55.1.0 (current) Built [ 40.704s] (current) Parsing datafusion-physical-plan v55.1.0 (current) Parsed [ 0.171s] (current) Building datafusion-physical-plan v55.1.0 (baseline) Built [ 39.836s] (baseline) Parsing datafusion-physical-plan v55.1.0 (baseline) Parsed [ 0.170s] (baseline) Checking datafusion-physical-plan v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.660s] 223 checks: 222 pass, 1 fail, 0 warn, 31 skip --- failure method_parameter_count_changed: pub method parameter count changed --- Description: A publicly-visible method now takes a different number of parameters, not counting the receiver (self) parameter. ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/method_parameter_count_changed.ron Failed in: datafusion_physical_plan::aggregates::order::GroupOrderingPartial::try_new takes 1 parameters in /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/f21327a82077111b9b4c853401cc0ffab505dbc6/datafusion/physical-plan/src/aggregates/order/partial.rs:120, but now takes 2 parameters in /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/aggregates/order/partial.rs:123 datafusion_physical_plan::aggregates::order::GroupOrdering::try_new takes 1 parameters in /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/f21327a82077111b9b4c853401cc0ffab505dbc6/datafusion/physical-plan/src/aggregates/order/mod.rs:44, but now takes 2 parameters in /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/aggregates/order/mod.rs:45 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 82.702s] datafusion-physical-plan ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
