dd-annarose commented on code in PR #25337:
URL: https://github.com/apache/datafusion/pull/25337#discussion_r4096234068
##########
datafusion/functions-aggregate/src/percentile_cont.rs:
##########
@@ -517,7 +555,8 @@ where
}
fn evaluate(&mut self) -> Result<ScalarValue> {
- let value = calculate_percentile::<T, I>(&mut self.all_values,
self.percentile)?;
+ let percentile = effective_percentile(&self.percentile,
self.is_descending)?;
Review Comment:
good catch, thanks! fixed and added tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
