namanjain24-sudo commented on issue #25708: URL: https://github.com/apache/datafusion/issues/25708#issuecomment-5818663567
Thanks for the detailed writeup @mohitgurav20! Looks like we both grabbed this around the same minute — I'd already taken it just before your comment landed, so I'll run with it, but your analysis is genuinely useful. Option 2 (checking whether anything above the aggregate actually reads the NULL-filled column or `GROUPING()`) is the same direction jayzhan211 pointed at in the issue, and your point about empty sets needing to stay guarded regardless is spot on. If you're looking for something else to pick up, there's a good chance more of these decorrelation edge cases turn up as I work through this one — happy to flag them here if so. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
