villebro commented on code in PR #1916:
URL:
https://github.com/apache/datafusion-ballista/pull/1916#discussion_r4096850124
##########
ballista/executor/src/lib.rs:
##########
@@ -138,14 +138,16 @@ pub fn as_task_status(
let metrics = operator_metrics.unwrap_or_default();
let task_id = key.task_id;
match execution_result {
- Ok(partitions) => {
+ Ok(shuffle_write_result) => {
debug!(
"Task {task_id} finished with operator_metrics array size {} \
and {} runtime-stats report(s), {} window-state report(s)",
metrics.len(),
runtime_stats.len(),
window_state.len(),
);
+ let partition = shuffle_write_result.partitions;
Review Comment:
nit:
```suggestion
let partitions = shuffle_write_result.partitions;
```
##########
ballista/executor/src/lib.rs:
##########
@@ -157,8 +159,9 @@ pub fn as_task_status(
metrics,
status: Some(task_status::Status::Successful(SuccessfulTask {
executor_id,
- partitions,
+ partitions: partition,
Review Comment:
..continuation of the previous nit:
```suggestion
partitions: partitions,
```
##########
ballista/core/proto/ballista.proto:
##########
@@ -829,6 +829,12 @@ message FailedTask {
}
}
+message TaskColumnStats {
+ uint32 column = 1;
+ uint64 null_count = 2;
+ bytes hll_sketch = 3;
Review Comment:
At the risk of opening a can of overabstraction, this feels very specific
(only single HLL sketch supported). Could we consider generalizing to support
arbitrary sketch types and counts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
