2010YOUY01 commented on PR #25574: URL: https://github.com/apache/datafusion/pull/25574#issuecomment-5824905244
> The hand-written `col = literal` match covers only one shape and duplicates `infer_join_predicates_impl` in this file. Every matching pair has equal keys, so any deterministic predicate over only left key columns also holds for the matching right keys. Reusing the helper also mirrors `IN`, ranges and `OR` on the key. The same-type check can go: coercion already wraps mismatched keys in `CAST`, so they are never direct columns. I tried this locally and `asof_join.slt` passes unchanged. It's fine to do this in a follow-up. I think this util is a neat idea, but a bit hard to wrap my head around and get convinced it's safe to reuse; However we can implement something similar for ASOF joins. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
