2010YOUY01 commented on PR #25574: URL: https://github.com/apache/datafusion/pull/25574#issuecomment-5824961136
> ## Performance > Q09 has 1M rows on each side across 10K equality groups. `WHERE l.key = 42` retains one group and produces 100 rows with both revisions. On an Apple M4 Max, using release builds and two 7-iteration runs per revision, the median elapsed time across all 14 iterations was: > > Revision Median elapsed > `main` without this optimization (`b172f73f0`) 21.5 ms > This change (`b3fd5f1f9`) 2.8 ms > This selective keyed workload is about **7.8x faster** (87% lower elapsed time). The benchmark file and command were the same for both binaries: > > ```shell > target/release/benchmark_runner asof_join --query 9 --iterations 7 > ``` > > The branch was subsequently synced through `21a3215b6`; those upstream-only commits do not touch the optimizer or ASOF paths exercised by Q09. nit: We could scale this benchmark query up so a run takes around 1s. At ~2ms per run, the numbers are easily swayed by noise, e.g. a false-positive 2x slowdown. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
