dwsmith1983 commented on PR #5654: URL: https://github.com/apache/datafusion-comet/pull/5654#issuecomment-5825420768
The PR now follows the table. It keeps the relabel gate in `cast_column.rs`, the nested duplicate-id error in `match_struct_fields` and the brackets in the `2094` message, each as sketched inline. The root change is dropped and main's behaviour stays, the shield keeps main's order, and the `FieldMapping` machinery, the list changes and the renames are on a side branch for a follow-up PR with a benchmark case. The tests follow the keep list: the swapped-id cast test, the three drop-and-re-add tests merged into one table-driven test with the swapped row, the requested and unrequested duplicate-id pair, the `DataSourceExec` scan over a file with a duplicated id, the struct duplicate-id Scala test and the message check in `multiple id matches`. The rationale for `known_divergence_repeated_root_name_rejects_unambiguous_field_id` is now a comment on `id_duplicate_roots`, and that test is gone with the others you listed. Against main the diff is +459/-76 across `error.rs`, `cast_column.rs`, `parquet_support.rs`, `schema_adapter.rs`, `ParquetReadSuite` and `CometNativeReaderSuite`. `ParquetReadV1Suite` and `CometNativeReaderSuite` pass on the 3.5, 4.0 and 4.1 profiles. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
