rgbuilds commented on PR #25530: URL: https://github.com/apache/datafusion/pull/25530#issuecomment-5828325913
@CuteChuanChuan I picked up the CrossJoinExec portion of #25333 in this PR. Since you outlined the join-metrics test approach, could you take a look at whether these batch-size cases and metric assertions cover what you had in mind? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
