dwsmith1983 commented on PR #6059: URL: https://github.com/apache/datafusion-comet/pull/6059#issuecomment-5832544556
The OAuth handling now follows the resolved provider class. Only the keys that class reads are translated and checked, so a shared configuration with settings for other providers builds for the one the account selects, and the store sees only what Hadoop would read. The explicit `SimpleKeyProvider` is accepted with the account key and still rejected without it, and custom key providers are still rejected. The module docs and the user guide describe both rules. A `ClientCredsTokenProvider` configuration with a client id and secret but no `fs.azure.account.oauth2.client.endpoint`, whose tenant came only from `fs.azure.account.oauth2.msi.tenant`, used to build and now fails, which matches Hadoop, where `AbfsConfiguration.getTokenProvider` reads the endpoint with `getMandatoryPasswordString(FS_AZURE_ACCOUNT_OAUTH_CLIENT_ENDPOINT)` for that class. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
