IgnatiusPang commented on PR #25744: URL: https://github.com/apache/datafusion/pull/25744#issuecomment-5841656090
Thanks @alamb! That makes complete sense. I've updated the PR accordingly: 1. I removed the unit test block and in-code comments from `cosine_distance.rs` to avoid stale commentary and keep the implementation minimal. 2. I've expanded `cosine_distance.slt` with end-to-end SQL test cases verifying both distance values (`0.0`, `2.0`) and metric bounding predicates (`>= 0.0`, `<= 2.0`) on identical and opposite 3D vectors. Ready for another look when you have a moment! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
