LucaCappelletti94 commented on PR #2592: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2592#issuecomment-5853553828
> I haven't looked at the PR, but the basic idea sounds reasonable The gist is what you imagine, box-ifying all entries in the statements enum, fixing the associated code. My goal here was primarily to measure how big of an impact the change would have. > 2. How will downstream crates need to be updated (can they still use `match ...` type statements) This is most likely to be **the** pain point: https://github.com/LucaCappelletti94/sqlparser-rs/blob/57c822b1b33a9612a016a45d40692cc39afdb40d/tests/sqlparser_postgres.rs#L347-L361 > 1. What will this do to parsing speed (every Box is another allocation) -- we should probably measure that I was expecting a slow down, but the size of the enum is currently so massive in my 12k statements corpus it accelerated by 10%. Out of caution, I will prepare another benchmark based on https://sql-ast-benchmark.luca.phd/ corpus and get back to you with those results. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
