milenkovicm commented on code in PR #2498:
URL:
https://github.com/apache/datafusion-ballista/pull/2498#discussion_r4116850730
##########
ballista/scheduler/src/cluster/memory.rs:
##########
@@ -308,7 +310,7 @@ impl InMemoryJobState {
queued_jobs: Default::default(),
running_jobs: Default::default(),
//sessions: Default::default(),
- session_builder,
+ session_builder: share_file_statistics_cache(session_builder),
Review Comment:
if we wrap session_builder here it would push caching all the time, users
would not be able to override it / disable it. Would it make sense to wrap
builder at one of following places
-
https://github.com/apache/datafusion-ballista/blob/32ceaf84072b0f721967d598d2735897c84c641b/ballista/scheduler/src/cluster/mod.rs#L116
-
https://github.com/apache/datafusion-ballista/blob/32ceaf84072b0f721967d598d2735897c84c641b/ballista/core/src/utils.rs#L158
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
