V0ldek commented on issue #25603: URL: https://github.com/apache/datafusion/issues/25603#issuecomment-5869979674
> If you’ve already started, let me know and I’ll review your PR instead. I plan to add serializer_registry() to Session and update the Substrait APIs to accept &dyn Session. No I didn't, go ahead :) > One question: the consumer currently uses SessionState::schema_for_ref to look up tables, including information_schema. Would exposing this lookup through Session make sense? With the context of `Session` docs and #10782 I'd say `schema_for_ref` is something the trait should reasonably provide, and there doesn't seem to be a way to implement it from the outside (since `information_schema` is not publicly exposed). So I think the answer is yes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
