andygrove commented on issue #4358: URL: https://github.com/apache/datafusion-comet/issues/4358#issuecomment-5870666411
I don't think this is worth doing anymore. A `ColumnarValue` signature would not remove the row count, since DataFusion's own `ScalarFunctionArgs` carries `number_rows` next to its `ColumnarValue` args for calls with no array argument, which is why #4306 added `numRows` to `CometUDF`. `CometUDF` now has a single implementation, the codegen dispatcher, and the native UDF ABI in #4459 keeps DataFusion types out on purpose and reserves a `scalar_args` slot for binding literals later. I think we can close this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
