andygrove commented on issue #1269: URL: https://github.com/apache/datafusion-comet/issues/1269#issuecomment-5870660654
Each function on this list now has its own SQL file test under sql-tests/expressions/array covering NULL and empty arrays, and array_remove and array_contains also have all-types tests in CometArrayExpressionSuite. One gap applies to all of them: the fixtures insert a handful of rows at a time, and under local[5] an insert of five rows or fewer writes one Parquet file per row, so most batches these tests see hold a single row. That is likely why the panic in #5269 needs seven rows to reproduce. I think we can close this and track multi-row batch coverage for the SQL file tests separately. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
