aetosdios27 opened a new pull request, #25836:
URL: https://github.com/apache/datafusion/pull/25836

   ## Which issue does this PR close?
   
   Closes #24868.
   
   ## Rationale for this change
   
   Microbenchmarks can compile successfully but panic when executed. Running 
their cases in CI catches stale benchmark fixtures and invocation assumptions 
without collecting performance measurements.
   
   ## What changes are included in this PR?
   
   - Add `cargo xtask ci step test microbenchmarks` and a required extended CI 
job. Following the existing workflow convention, it runs in the merge queue, on 
release-branch pushes, and manually; it skips PR events.
   - Execute Criterion bench targets in test mode with `--no-fail-fast`, 
including the physical-plan benchmarks gated by `test_utils`. The `ci-bench` 
profile retains workspace debug assertions and overflow checks with light 
optimization to keep larger cases practical.
   - Use the checked-in ten-row ClickBench fixture for SQL planner smoke tests 
through `CLICKBENCH_DATA_PATH`. Ordinary performance runs retain their 
full-dataset default. The separate SQL benchmark harness, which requires 
generated datasets, remains covered by its existing jobs.
   - Fix benchmark failures exposed by execution: timestamp timezone metadata, 
power and Spark slice input coercion, string return types, and repeat row 
counts/error assertions. Coercions for power and slice happen before timing the 
UDF.
   
   ## What is the testing strategy for this PR?
   
   - All 127 benchmark targets verified across the full smoke run and targeted 
reruns after fixing the failing fixtures.
   - Four xtask tests pass, including command/environment snapshot coverage for 
the new step.
   - `cargo fmt --all`, `cargo clippy --all-targets --all-features -- -D 
warnings`, and the complete `./dev/rust_lint.sh` suite pass.
   - Extended workspace tests were run. The existing 
`sort_with_mem_limit_1_runner` RSS assertion failed intermittently in parallel 
execution; the complete core integration target passed when rerun serially 
(1,221 passed, one ignored). The other extended test targets passed. No 
memory-test code or limits were changed.
   
   ## Are there any user-facing changes?
   
   No query behavior or public API changes. Benchmark contributors gain a local 
smoke-test command and automated execution coverage.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to