sunchao commented on code in PR #5750: URL: https://github.com/apache/datafusion-comet/pull/5750#discussion_r4124970413
########## spark/src/test/resources/sql-tests/expressions/array/array_distinct.sql: ########## @@ -15,6 +15,9 @@ -- specific language governing permissions and limitations -- under the License. +-- No negative zeros in this fixture; signed-zero compatibility is tested in array_set_signed_zero*. Review Comment: [P2] Update the parser regression alongside the fixture move. `SqlFileTestParserSuite` still requires an ignored signed-zero literal query in each of `array_distinct.sql`, `array_union.sql`, `array_except.sql` and `array_intersect.sql`. Removing those queries makes the suite fail deterministically at line 191 with `array_distinct.sql is missing an ignored signed-zero literal query`, blocking the required expression build. The relocated executable coverage should pass the suite. Update its old fixture invariant to check the new version-specific files and their expected modes. Evidence: Compiled the checkout’s unchanged `SqlFileTestParser.scala` and `SqlFileTestParserSuite.scala` in a disposable directory and ran `org.scalatest.tools.Runner -s org.apache.comet.SqlFileTestParserSuite`: head fixtures produced 12 passes and this failure; substituting the four base fixtures produced 13 passes. The exact-head CI expression job reproduces the identical assertion: https://github.com/apache/datafusion-comet/actions/runs/36243570425/job/108409746688. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
