sunchao commented on code in PR #25428: URL: https://github.com/apache/datafusion/pull/25428#discussion_r4125259993
########## datafusion/sqllogictest/test_files/aggregate_memory_spill.slt: ########## @@ -198,6 +198,11 @@ FROM ( statement ok SET datafusion.execution.target_partitions = 4 +# Bound merge buffers so each partition can allocate replay state while the +# other partitions retain aggregate state in the shared greedy memory pool. +statement ok +SET datafusion.runtime.max_spill_merge_fan_in = 2 Review Comment: Closing the loop on the current head, `78c4b7b`: this PR no longer widens merges or changes Case G. Its fan-in cap and the reference to #25423 are inherited unchanged from the comparison base. The remaining sizing path only reduces an already admitted selection, and an actually trimmed pass retains its existing grant through the write for the next admission. The deterministic competing-consumer tests cover both replay-headroom release and intermediate EOF. The earlier reply above describes a superseded revision; the current scope and tests are in the PR description. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
