mohitgurav20 commented on PR #6324: URL: https://github.com/apache/datafusion-comet/pull/6324#issuecomment-5876286334
Hi @andygrove, thanks for the review and the great suggestions! I've just pushed a commit to address your feedback: Added the duplicate-name reason to CometArraysZip.getUnsupportedReasons() so it correctly surfaces in the generated compatibility guide. Moved the test out of CometExpressionSuite.scala and into spark/src/test/resources/sql-tests/expressions/array/arrays_zip.sql using the expect_fallback directive, ensuring we specifically test the fallback guard as intended. Thanks again for the approval! Let me know if there's anything else needed before merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
