andygrove commented on PR #4727: URL: https://github.com/apache/datafusion-comet/pull/4727#issuecomment-5892102724
`dev/diffs/4.2.0.diff` landed on main in #4950 after this PR was written, so it is missing the `DataFrameAggregateSuite` change this PR makes to the 3.4 through 4.1 diffs. Spark 4.2.0 has the same `assert(objHashAggOrSortAggPlan.isInstanceOf[ObjectHashAggregateExec])` in `assertNoExceptions`, which "SPARK-19471: AggregationIterator does not initialize the generated result projection before using it" runs. So the 4.2 diff probably needs the same `CometHashAggregateExec` relaxation. The [Spark SQL Tests guide](https://datafusion.apache.org/comet/contributor-guide/spark-sql-tests.html) covers regenerating a diff. I've added the `run-spark-4.2-tests` label so CI runs the Spark 4.2 SQL suite here. It needs two things before it can give a result: - The merge conflicts must be resolved. GitHub doesn't run workflows on a PR with conflicts. - #6398 must be merged. Until then, the 4.2 build fails trying to resolve Comet `1.1.0-SNAPSHOT` (#6380). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
