Weijun-H commented on code in PR #25872:
URL: https://github.com/apache/datafusion/pull/25872#discussion_r4135062786
##########
datafusion/functions-aggregate/src/min_max.rs:
##########
@@ -283,76 +274,10 @@ impl AggregateUDFImpl for Max {
args: AccumulatorArgs,
) -> Result<Box<dyn GroupsAccumulator>> {
use DataType::*;
- use TimeUnit::*;
let data_type = args.return_field.data_type();
- match data_type {
- Int8 => primitive_max_accumulator!(data_type, i8, Int8Type),
- Int16 => primitive_max_accumulator!(data_type, i16, Int16Type),
- Int32 => primitive_max_accumulator!(data_type, i32, Int32Type),
- Int64 => primitive_max_accumulator!(data_type, i64, Int64Type),
- UInt8 => primitive_max_accumulator!(data_type, u8, UInt8Type),
- UInt16 => primitive_max_accumulator!(data_type, u16, UInt16Type),
- UInt32 => primitive_max_accumulator!(data_type, u32, UInt32Type),
- UInt64 => primitive_max_accumulator!(data_type, u64, UInt64Type),
- Float16 => {
- primitive_max_accumulator!(data_type, f16, Float16Type, total,
u16)
- }
- Float32 => {
- primitive_max_accumulator!(data_type, f32, Float32Type, total,
u32)
- }
- Float64 => {
- primitive_max_accumulator!(data_type, f64, Float64Type, total,
u64)
- }
- Date32 => primitive_max_accumulator!(data_type, i32, Date32Type),
- Date64 => primitive_max_accumulator!(data_type, i64, Date64Type),
- Time32(Second) => {
- primitive_max_accumulator!(data_type, i32, Time32SecondType)
- }
- Time32(Millisecond) => {
- primitive_max_accumulator!(data_type, i32,
Time32MillisecondType)
- }
- Time64(Microsecond) => {
- primitive_max_accumulator!(data_type, i64,
Time64MicrosecondType)
- }
- Time64(Nanosecond) => {
- primitive_max_accumulator!(data_type, i64,
Time64NanosecondType)
- }
- Timestamp(Second, _) => {
- primitive_max_accumulator!(data_type, i64, TimestampSecondType)
- }
- Timestamp(Millisecond, _) => {
- primitive_max_accumulator!(data_type, i64,
TimestampMillisecondType)
- }
- Timestamp(Microsecond, _) => {
- primitive_max_accumulator!(data_type, i64,
TimestampMicrosecondType)
- }
- Timestamp(Nanosecond, _) => {
- primitive_max_accumulator!(data_type, i64,
TimestampNanosecondType)
- }
- Duration(Second) => {
- primitive_max_accumulator!(data_type, i64, DurationSecondType)
- }
- Duration(Millisecond) => {
- primitive_max_accumulator!(data_type, i64,
DurationMillisecondType)
- }
- Duration(Microsecond) => {
- primitive_max_accumulator!(data_type, i64,
DurationMicrosecondType)
- }
- Duration(Nanosecond) => {
- primitive_max_accumulator!(data_type, i64,
DurationNanosecondType)
- }
- Decimal32(_, _) => {
- primitive_max_accumulator!(data_type, i32, Decimal32Type)
- }
- Decimal64(_, _) => {
- primitive_max_accumulator!(data_type, i64, Decimal64Type)
- }
- Decimal128(_, _) => {
- primitive_max_accumulator!(data_type, i128, Decimal128Type)
- }
- Decimal256(_, _) => {
- primitive_max_accumulator!(data_type, i256, Decimal256Type)
- }
+
+ downcast_primitive! {
+ data_type => (primitive_max_accumulator, data_type),
Review Comment:
Preserve the float-specific branches in both factories
This dispatch replaces `total_cmp` and its sentinels with `partial_cmp` and
finite bounds. Through the actual Float32 factories, MIN([+Infinity]) returns
`f32::MAX` and MAX([-Infinity]) returns `f32::MIN`; NaN and signed-zero cases
also regress. Retain the float-specific branches and test via the factories—the
existing test calls the `total` helper directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
