andygrove opened a new issue, #6402:
URL: https://github.com/apache/datafusion-comet/issues/6402

   ## What / Why
   
   This tracks regressions against 1.0.0 that came in with PRs merged for 
1.1.0, as the audit in #6399 finds them. It is a work in progress. I'll keep 
updating this description as the audit confirms or rules things out, so the 
list is incomplete until #6399 is finished, and the WIP comes off the title 
then.
   
   A regression here is something that worked in 1.0.0 and is broken or worse 
in 1.1.0: wrong or silently different results, a new failure, a loud failure 
that became a silent wrong answer, a slower default path, or a config behavior 
change. Bugs that already shipped in 1.0.0 aren't listed, and neither are bugs 
in new features that are off by default.
   
   ## Ships in 1.1.0
   
   None confirmed so far. The fixes that merged to `main` after the branch cut 
without reaching `branch-1.1` have all been checked (#6261, #5880, #5403, #5846 
and #5169), and all five fix bugs that were already in 1.0.0.
   
   ## Fixed before 1.1.0-rc1
   
   These were introduced and fixed inside the 1.1.0 window, so they don't ship. 
Each got through review and was caught after merge.
   
   - [x] #5602 made the native scan return extra or wrong rows for a Parquet 
struct with byte-identical child field names, where 1.0.0 panicked (#5783). 
Fixed by #5786. #5602 was tested against what it targeted, Spark's 
case-insensitive duplicate-field error, and no test built the case-sensitive 
duplicate it left behind.
   - [x] #5262 bumped DataFusion to 55 and iceberg-rust to a version whose 
`FileScanTask` builder validates its input. After that, native Iceberg scans, 
which are on by default, failed on tables partitioned by a transform 
iceberg-rust doesn't know (#5758). Fixed by #5759. The pull request CI doesn't 
run the Iceberg suites, and Iceberg's `TestForwardCompatibility` caught it 
after merge.
   - [x] #5314 moved the libhdfs routing check after the `s3a` to `s3` alias 
rewrite, so listing `s3` without `s3a` in `fs.comet.libhdfs.schemes` sent 
`s3a://` reads through libhdfs instead of the native S3 store. Fixed by #5825. 
Its tests covered the rewrite and the default scheme list, but not a list 
naming only one of the two.
   
   ## Progress
   
   Phase 1 of #6399 has checked 55 of its 83 fix to origin links: 3 regressions 
(above), 25 bugs in functionality that is new in 1.1.0 and didn't break 
anything that worked in 1.0.0, 25 bugs that were already in 1.0.0, and 2 fixes 
that weren't for a defect.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to