andygrove commented on PR #5859: URL: https://github.com/apache/datafusion-comet/pull/5859#issuecomment-5911347275
Now that this is merged with main it builds under #5876's strict-warnings profile, and `Strict Scala warnings (Spark 3.5, JDK 17)` fails on two implicit numeric widenings in `CometInMemoryCacheBenchmark.runWideSparkOperatorBenchmark`. `rows` is an `Int` (`20 * 1000 * 1000 / width`), and it goes to `spark.range` at line 423 and to `new Benchmark` at line 431, which both take a `Long`. Could you make it `20L * 1000 * 1000 / width`? That fixes both. It reproduces locally with `./mvnw test-compile -Pspark-3.5 -Pstrict-warnings -DskipTests`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
