dwsmith1983 commented on PR #6405: URL: https://github.com/apache/datafusion-comet/pull/6405#issuecomment-5906080035
> Could we open the branch-55 backport first and hold this PR until we know whether 55.2.0 carries it? Yes. The backport is apache/datafusion#25895, a clean cherry-pick of #24790 onto `branch-55`, linked from #25758. I'll hold this PR until we know whether 55.2.0 carries it, and if it does, this PR shrinks to the tests after the version bump. > would a `CometScanRule` fallback for scans that request an id on a struct, array or map field be enough as a stopgap? I think so, and it's up as #6444: when field id reads are on and the requested schema has an id on a struct, array or map field, the scan falls back to Spark. Variant fields on Spark 4.x lose their id the same way, so they're included too. A native test fails once DataFusion keeps those ids, which flags when the fallback can come out. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
