andygrove commented on PR #6382: URL: https://github.com/apache/datafusion-comet/pull/6382#issuecomment-5915639293
`dev/diffs/3.4.3.diff` has the same broken edit, and this PR doesn't touch it. In `Reuse the default parallelism in local shuffle read` it changes `assert(localReads.length == 2)` to `== 1` (around line 1681 of the diff on `main`), and `localReads(1)` still follows two lines later. I missed it when I filed #6122 and only listed three diffs. Could we fix 3.4.3 in this PR as well, using the same apply, edit and `git diff` steps from `spark-sql-tests.md` against `v3.4.3`? Then `Closes #6122` won't leave a broken diff behind. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
