geoffreyclaude commented on code in PR #25186:
URL: https://github.com/apache/datafusion/pull/25186#discussion_r4147186327
##########
datafusion/common/src/utils/mod.rs:
##########
@@ -1557,6 +1566,10 @@ pub fn normalize_float_zero_scalar(scalar: ScalarValue)
-> ScalarValue {
ScalarValue::Float16(Some(v)) if v.to_bits() << 1 == 0 => {
ScalarValue::Float16(Some(half::f16::from_bits(0)))
}
+ ScalarValue::Dictionary(key, mut value) => {
+ *value = normalize_float_zero_scalar(*value);
+ ScalarValue::Dictionary(key, value)
+ }
other => other,
Review Comment:
You're right, I'll see if I can squeeze those in without blowing up the PR.
Otherwise I'd prefer keeping it to a new PR: this one was really meant as a fix
of the incorrect zero logic I introduced in the IN LIST optim PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
