rluvaton commented on code in PR #25877:
URL: https://github.com/apache/datafusion/pull/25877#discussion_r4147740625
##########
datafusion/physical-plan/src/aggregates/spill.rs:
##########
@@ -248,6 +248,22 @@ impl AggregateSpill {
Ok(())
}
+ /// [`Self::sort_and_spill`] for the state batches of a hash aggregate
+ /// table: one batch for flat storage, one per block for blocked storage,
+ /// each written as its own spill file.
+ pub(super) fn sort_and_spill_batches(
+ &mut self,
+ state_batches: Vec<MaterializedBatch>,
+ ) -> Result<()> {
+ // TODO: sort across multiple arrays without concat (see #24928
Review Comment:
used your snippet in the meantime
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
