parthchandra commented on PR #6348: URL: https://github.com/apache/datafusion-comet/pull/6348#issuecomment-5919289158
The one-line UTC change matches iceberg-java (`Timestamps.DAY` measures from a UTC epoch), and it doesn't conflict with #6456 (different code path). One note: - **`spark/src/main/scala/org/apache/comet/serde/datetime.scala:850`** — for pre-1970 timestamps whose microsecond-of-second is 999999, this true-floor UTC cast lands one day off from iceberg's `microsToDays`, which is what #6456 corrects on the kernel path. Since #6456 doesn't touch this cast route, please add a short note that `CometDays` stays a true floor and mention that edge, so the two "days" paths' behavior is documented rather than surprising later. Because this changes a transform Iceberg partitions by, worth applying `run-iceberg-tests` or running a local 3.4/3.5 job before merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
